Issue 369603004: Work on GN build, mostly in //ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369603004: Work on GN build, mostly in //ui (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
awong

CC:
chromium-reviews, ben+aura_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Work on GN build, mostly in //ui This fills out a number of ui targets and does some changes to the resources to match the GYP build. In particular, we had a number of different ui/resources targets that were depended on independently. The GYP build has only one, so I combined them into a meta "ui/resources" target. Adds a grit repack template. TBR=ajwong Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281087

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+419 lines, -31 lines)			Patch
M	BUILD.gn	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download
M	build/repack_action.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	build/secondary/tools/grit/repack.gni	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View		11 chunks	+12 lines, -12 lines	0 comments	Download
M	content/browser/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/aura.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A	ui/keyboard/BUILD.gn	View		1 chunk	+89 lines, -0 lines	0 comments	Download
M	ui/keyboard/keyboard.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/resources/BUILD.gn	View		1 chunk	+69 lines, -4 lines	0 comments	Download
M	ui/resources/ui_resources.gyp	View		4 chunks	+5 lines, -0 lines	0 comments	Download
A	ui/web_dialogs/BUILD.gn	View		1 chunk	+40 lines, -0 lines	0 comments	Download
D	ui/webui/resources/BUILD.gn	View		1 chunk	+0 lines, -10 lines	0 comments	Download
A	ui/wm/BUILD.gn	View		1 chunk	+143 lines, -0 lines	0 comments	Download
M	ui/wm/wm.gyp	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #3 manually as r281087 (presubmit successful).

6 years, 5 months ago (2014-07-02 20:39:16 UTC) #1

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages

Issue 369603004: Work on GN build, mostly in //ui (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : android #

Messages