src/IceInstX8632.def - Issue 369573005: Avoid assigning esp (or ebp for framepointer-using frames) in Om1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8632.def

Issue 369573005: Avoid assigning esp (or ebp for framepointer-using frames) in Om1. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: add comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8632.def

diff --git a/src/IceInstX8632.def b/src/IceInstX8632.def

index d9473eb289b1e9816e7dd0b55a241ae6cc1d8eef..be7c505c1ec3a8693aa6428484a35fd09215f7c4 100644

--- a/src/IceInstX8632.def

+++ b/src/IceInstX8632.def

@@ -15,6 +15,7 @@

#ifndef SUBZERO_SRC_ICEINSTX8632_DEF

#define SUBZERO_SRC_ICEINSTX8632_DEF

+// NOTE: esp is not considered isInt, to avoid register allocating it.

#define REGX8632_TABLE \

/* val, init, name, name16, name8, scratch, preserved, stackptr, \

frameptr, isI8, isInt, isFP */ \

@@ -22,7 +23,7 @@

X(Reg_ecx, = Reg_eax + 1, "ecx", "cx", "cl", 1, 0, 0, 0, 1, 1, 0) \

X(Reg_edx, = Reg_eax + 2, "edx", "dx", "dl", 1, 0, 0, 0, 1, 1, 0) \

X(Reg_ebx, = Reg_eax + 3, "ebx", "bx", "bl", 0, 1, 0, 0, 1, 1, 0) \

- X(Reg_esp, = Reg_eax + 4, "esp", "sp", "" , 0, 0, 1, 0, 0, 1, 0) \

+ X(Reg_esp, = Reg_eax + 4, "esp", "sp", "" , 0, 0, 1, 0, 0, 0, 0) \

X(Reg_ebp, = Reg_eax + 5, "ebp", "bp", "" , 0, 1, 0, 1, 0, 1, 0) \

X(Reg_esi, = Reg_eax + 6, "esi", "si", "" , 0, 1, 0, 0, 0, 1, 0) \

X(Reg_edi, = Reg_eax + 7, "edi", "di", "" , 0, 1, 0, 0, 0, 1, 0) \

« no previous file with comments | « no previous file | src/IceTargetLowering.cpp » ('j') | no next file with comments »