chrome/browser/ui/views/message_center/web_notification_tray.cc - Issue 369573004: Separate the logic of popup alignment and workarea handling as delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray.cc

Issue 369573004: Separate the logic of popup alignment and workarea handling as delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: polish Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/web_notification/popup_alignment_delegate.cc ('K') | « chrome/browser/ui/views/message_center/web_notification_tray.h ('k') | ui/message_center/message_center.gyp » ('j') | ui/message_center/views/popup_alignment_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/message_center/web_notification_tray.cc

diff --git a/chrome/browser/ui/views/message_center/web_notification_tray.cc b/chrome/browser/ui/views/message_center/web_notification_tray.cc

index c28f2bef3de7603b2fbe5f7303d48d6ea97696a9..66960da74bb0327f88e382486494226ebf4a90c2 100644

--- a/chrome/browser/ui/views/message_center/web_notification_tray.cc

+++ b/chrome/browser/ui/views/message_center/web_notification_tray.cc

@@ -27,6 +27,7 @@

#include "ui/gfx/size.h"

#include "ui/message_center/message_center_tray.h"

#include "ui/message_center/message_center_tray_delegate.h"

+#include "ui/message_center/views/desktop_popup_alignment_delegate.h"

#include "ui/message_center/views/message_popup_collection.h"

#include "ui/views/widget/widget.h"

@@ -135,8 +136,11 @@ WebNotificationTray::WebNotificationTray(PrefService* local_state)

message_center_tray_.reset(

new MessageCenterTray(this, g_browser_process->message_center()));

last_quiet_mode_state_ = message_center()->IsQuietMode();

+ alignment_delegate_.reset(new message_center::DesktopPopupAlignmentDelegate);

popup_collection_.reset(new message_center::MessagePopupCollection(

- NULL, message_center(), message_center_tray_.get(), false));

+ NULL, message_center(), message_center_tray_.get(),

+ alignment_delegate_.get()));

+ alignment_delegate_->StartObserving(gfx::Screen::GetNativeScreen());

#if defined(OS_WIN)

// |local_state| can be NULL in tests.