ash/system/web_notification/web_notification_tray.h - Issue 369573004: Separate the logic of popup alignment and workarea handling as delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/web_notification/web_notification_tray.h

Issue 369573004: Separate the logic of popup alignment and workarea handling as delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: polish Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/web_notification/popup_alignment_delegate.cc ('K') | « ash/system/web_notification/popup_alignment_delegate_unittest.cc ('k') | ash/system/web_notification/web_notification_tray.cc » ('j') | ui/message_center/views/popup_alignment_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/web_notification/web_notification_tray.h

diff --git a/ash/system/web_notification/web_notification_tray.h b/ash/system/web_notification/web_notification_tray.h

index 887a91ddb536a6c9ba3bd87770453824999b56d5..4c94424969158b1cb28a8f4594caeef511e698f2 100644

--- a/ash/system/web_notification/web_notification_tray.h

+++ b/ash/system/web_notification/web_notification_tray.h

@@ -41,7 +41,7 @@ namespace ash {

class StatusAreaWidget;

class WebNotificationBubbleWrapper;

class WebNotificationButton;

-class WorkAreaObserver;

+class PopupAlignmentDelegate;

class ASH_EXPORT WebNotificationTray

: public TrayBackgroundView,

@@ -175,8 +175,7 @@ class ASH_EXPORT WebNotificationTray

// flickers of the shelf from hidden to shown. See: crbug.com/181213

bool should_block_shelf_auto_hide_;

- // Observes the work area for |popup_collection_| and notifies to it.

- scoped_ptr<WorkAreaObserver> work_area_observer_;

+ scoped_ptr<PopupAlignmentDelegate> popup_alignment_delegate_;

DISALLOW_COPY_AND_ASSIGN(WebNotificationTray);

};