Remove dead code

Remove dead code

HistoryService no longer use CancelableRequest{Consumer,Producer} but
CancelableTaskTracker instead so remove the code that supported the
old API.

Fix the DCHECK in the methods of HistoryService that use thread_.

BUG=371818
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285171

[sdefresne, 2014-07-02 17:42:53]

blundell: Please have a look.

kalman: Please review //chrome/browser/extensions/api as OWNER

[not at google - send to devlin, 2014-07-02 18:14:20]

extensions lgtm

[blundell, 2014-07-03 08:29:13]

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
File chrome/browser/history/top_sites_impl.cc (left):

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
chrome/browser/history/top_sites_impl.cc:461: &cancelable_task_tracker_);
is this a bugfix?

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
File chrome/browser/history/top_sites_impl.h (right):

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
chrome/browser/history/top_sites_impl.h:236: // Need a separate task tracker 
for each CancelableRequestProvider we
comment is out of date

[sdefresne, 2014-07-22 14:29:07]

blundell: PTAL

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
File chrome/browser/history/top_sites_impl.cc (left):

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
chrome/browser/history/top_sites_impl.cc:461: &cancelable_task_tracker_);
On 2014/07/03 08:29:12, blundell wrote:
> is this a bugfix?

This is unnecessary and removed.

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
File chrome/browser/history/top_sites_impl.h (right):

https://codereview.chromium.org/369503007/diff/1/chrome/browser/history/top_s...
chrome/browser/history/top_sites_impl.h:236: // Need a separate task tracker 
for each CancelableRequestProvider we
On 2014/07/03 08:29:12, blundell wrote:
> comment is out of date

Done.

[blundell, 2014-07-22 15:19:57]

https://codereview.chromium.org/369503007/diff/40001/chrome/browser/history/t...
File chrome/browser/history/top_sites_impl.cc (right):

https://codereview.chromium.org/369503007/diff/40001/chrome/browser/history/t...
chrome/browser/history/top_sites_impl.cc:381:
cancelable_task_tracker_.TryCancelAll();
This is a behavioral change, as the two trackers have been merged into one. Do
you know that that's OK?

[sdefresne, 2014-07-22 15:41:54]

On 2014/07/22 15:19:57, blundell wrote:
>
https://codereview.chromium.org/369503007/diff/40001/chrome/browser/history/t...
> File chrome/browser/history/top_sites_impl.cc (right):
> 
>
https://codereview.chromium.org/369503007/diff/40001/chrome/browser/history/t...
> chrome/browser/history/top_sites_impl.cc:381:
> cancelable_task_tracker_.TryCancelAll();
> This is a behavioral change, as the two trackers have been merged into one. Do
> you know that that's OK?

I think so. The code used two consumer as consumer didn't support the same
object to send requests to differents thread but ConsumableTaskTracker does not
have that limitation. And the consumer were supposed to be both cleared in
Shutdown (which is currently broken).

[blundell, 2014-07-22 15:44:17]

lgtm

[not at google - send to devlin, 2014-07-22 16:31:10]

rslgtm

[sdefresne, 2014-07-23 07:46:31]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-07-23 07:47:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/369503007/60001

[commit-bot: I haz the power, 2014-07-23 09:45:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[commit-bot: I haz the power, 2014-07-23 09:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 09:48:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[sdefresne, 2014-07-24 08:16:53]

TBR=sky for //chrome/bowser/jumplist_win.h

[sdefresne, 2014-07-24 08:17:03]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-07-24 08:19:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/369503007/60001

[commit-bot: I haz the power, 2014-07-24 10:38:15]

Change committed as 285171