Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 369503003: Migration of code from ContentViewCore to NavigationController to avoid ContentViewCore abstraction… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed style issues in functions Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index fb33b0c5e7d794af00a8e32294740461142841c6..f574fcf48eec6ec81a954fefb2b11bbbfbf8031c 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1048,14 +1048,14 @@ public class ContentViewCore
* Loads the current navigation if there is a pending lazy load (after tab restore).
*/
public void loadIfNecessary() {
- if (mNativeContentViewCore != 0) nativeLoadIfNecessary(mNativeContentViewCore);
+ if (mWebContents != null) mWebContents.getNavigationController().loadIfNecessary();
}
/**
* Requests the current navigation to be loaded upon the next call to loadIfNecessary().
*/
public void requestRestoreLoad() {
- if (mNativeContentViewCore != 0) nativeRequestRestoreLoad(mNativeContentViewCore);
+ if (mWebContents != null) mWebContents.getNavigationController().requestRestoreLoad();
}
/**
@@ -1063,9 +1063,7 @@ public class ContentViewCore
*/
public void reload(boolean checkForRepost) {
mAccessibilityInjector.addOrRemoveAccessibilityApisIfNecessary();
- if (mNativeContentViewCore != 0) {
- nativeReload(mNativeContentViewCore, checkForRepost);
- }
+ if (mWebContents != null) mWebContents.getNavigationController().reload(checkForRepost);
}
/**
@@ -1073,23 +1071,22 @@ public class ContentViewCore
*/
public void reloadIgnoringCache(boolean checkForRepost) {
mAccessibilityInjector.addOrRemoveAccessibilityApisIfNecessary();
- if (mNativeContentViewCore != 0) {
- nativeReloadIgnoringCache(mNativeContentViewCore, checkForRepost);
- }
+ if (mWebContents != null) mWebContents.getNavigationController().reloadIgnoringCache(
+ checkForRepost);
}
/**
* Cancel the pending reload.
*/
public void cancelPendingReload() {
- if (mNativeContentViewCore != 0) nativeCancelPendingReload(mNativeContentViewCore);
+ if (mWebContents != null) mWebContents.getNavigationController().cancelPendingReload();
}
/**
* Continue the pending reload.
*/
public void continuePendingReload() {
- if (mNativeContentViewCore != 0) nativeContinuePendingReload(mNativeContentViewCore);
+ if (mWebContents != null) mWebContents.getNavigationController().continuePendingReload();
}
/**
@@ -3271,17 +3268,6 @@ public class ContentViewCore
private native void nativeSetMultiTouchZoomSupportEnabled(
long nativeContentViewCoreImpl, boolean enabled);
- private native void nativeLoadIfNecessary(long nativeContentViewCoreImpl);
- private native void nativeRequestRestoreLoad(long nativeContentViewCoreImpl);
-
- private native void nativeReload(long nativeContentViewCoreImpl, boolean checkForRepost);
- private native void nativeReloadIgnoringCache(
- long nativeContentViewCoreImpl, boolean checkForRepost);
-
- private native void nativeCancelPendingReload(long nativeContentViewCoreImpl);
-
- private native void nativeContinuePendingReload(long nativeContentViewCoreImpl);
-
private native void nativeSelectPopupMenuItems(long nativeContentViewCoreImpl, int[] indices);
private native void nativeScrollFocusedEditableNodeIntoView(long nativeContentViewCoreImpl);

Powered by Google App Engine
This is Rietveld 408576698