Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 369483004: Revert of Move paint invalidation after compositing update (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Move paint invalidation after compositing update (https://codereview.chromium.org/351673007/) Reason for revert: Tests fast/repaint/intermediate-layout-position-clip.html and fast/repaint/table-shrink-row-repaint.html start to fail after this change http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/repaint/intermediate-layout-position-clip.html,fast/repaint/table-shrink-row-repaint.html Original issue's description: > Move paint invalidation after compositing update > > Now that repaint-after-layout is the new world, we can make > invalidation its own phase. Moving it after compositing update > removes chicken-and-egg bugs that we had in the invalidation code. > > The new code invalidates from the layout roots up to the RenderView > so that we can always do a full tree traversal. This shouldn't > trigger extra invalidations and yield to a more simple code. > > I checked the new baselines visually and it's overall a neutral > change, where we do better one some tests > (e.g. fast/repaint/intermediate-layout-position-clip.html) and we > do worse on others (e.g. fast/repaint/layout-state-scrolloffset*). > The bulk of the text changes are invalidation going to a different > GraphicsLayer which indicates that we had some compositing > container changes not accounted for. > > BUG=360286 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177349 TBR=abarth@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org,ojan@chromium.org,jchaffraix@chromium.org NOTREECHECKS=true NOTRY=true BUG=360286 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -259 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -39 lines 0 comments Download
M LayoutTests/compositing/repaint/resize-repaint-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/compositing/squashing/add-remove-squashed-layers-expected.txt View 8 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/squashing/tricky-element-removal-crash-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/css3/flexbox/repaint-opacity-change-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-z-index-change-repaint-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/images/repaint-subrect-grid.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/background-resize-height-expected.txt View 22 chunks +22 lines, -32 lines 0 comments Download
M LayoutTests/fast/repaint/background-resize-width-expected.txt View 22 chunks +32 lines, -22 lines 0 comments Download
M LayoutTests/fast/repaint/border-radius-repaint-2-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/repaint/change-transform-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/fixed-and-absolute-position-scrolled-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/intermediate-layout-position-clip-expected.txt View 1 chunk +3 lines, -2 lines 0 comments Download
D LayoutTests/fast/repaint/multi-layout-one-frame.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/repaint/multi-layout-one-frame-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/fast/repaint/resources/line-flow-with-floats.js View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-background-image-generated-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-media-query-expected.txt View 3 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-percent-html-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-percent-width-height-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-vertical-writing-mode-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/compositing/squashing/remove-squashed-layer-plus-move-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/inline-outline-repaint-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/layout-state-scrolloffset-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/layout-state-scrolloffset2-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/layout-state-scrolloffset3-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/subtree-layoutstate-transform-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/table-shrink-row-repaint-expected.txt View 2 chunks +13 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/svg/as-image/animated-svg-as-image-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/as-image/animated-svg-as-image-same-image-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/carto.net/tabgroup-expected.txt View 5 chunks +139 lines, -30 lines 0 comments Download
M LayoutTests/platform/linux/svg/transforms/animated-path-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/transforms/animated-path-inside-transformed-html-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/softwarecompositing/squashing/remove-squashed-layer-plus-move-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/zoom/page/relative-sized-document-scrollbars-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/virtual/softwarecompositing/layer-creation/should-invoke-deferred-compositing-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/frame/FrameView.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 6 chunks +20 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
Created Revert of Move paint invalidation after compositing update
6 years, 5 months ago (2014-07-02 06:35:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/369483004/1
6 years, 5 months ago (2014-07-02 06:37:13 UTC) #2
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 5 months ago (2014-07-02 06:37:40 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 06:37:47 UTC) #4
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 5 months ago (2014-07-02 06:45:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/369483004/1
6 years, 5 months ago (2014-07-02 06:46:27 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 06:47:38 UTC) #7
Message was sent while issue was closed.
Change committed as 177352

Powered by Google App Engine
This is Rietveld 408576698