Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: Source/core/css/parser/SizesCalcParser.h

Issue 369423002: Have srcset respond to viewport changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Self review nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/SizesCalcParser.h
diff --git a/Source/core/css/parser/SizesCalcParser.h b/Source/core/css/parser/SizesCalcParser.h
index 5d18b30176e8572e439f1440215e2a889060af72..c6501ff8a6d08fb229e71f5caae0546ee9f85ddf 100644
--- a/Source/core/css/parser/SizesCalcParser.h
+++ b/Source/core/css/parser/SizesCalcParser.h
@@ -34,16 +34,14 @@ struct SizesCalcValue {
class SizesCalcParser {
public:
- static bool parse(MediaQueryTokenIterator start, MediaQueryTokenIterator end, PassRefPtr<MediaValues>, unsigned& result);
+ SizesCalcParser(MediaQueryTokenIterator start, MediaQueryTokenIterator end, PassRefPtr<MediaValues>);
+ bool viewportDependant() const { return m_viewportDependant; }
+ unsigned result();
+ bool isValid() const { return m_isValid; }
private:
- SizesCalcParser(PassRefPtr<MediaValues> mediaValues)
- : m_mediaValues(mediaValues)
- {
- }
-
bool calcToReversePolishNotation(MediaQueryTokenIterator start, MediaQueryTokenIterator end);
- bool calculate(unsigned& result);
+ bool calculate();
void appendNumber(const MediaQueryToken&);
bool appendLength(const MediaQueryToken&);
bool handleOperator(Vector<MediaQueryToken>& stack, const MediaQueryToken&);
@@ -51,6 +49,9 @@ private:
Vector<SizesCalcValue> m_valueList;
RefPtr<MediaValues> m_mediaValues;
+ bool m_viewportDependant;
+ bool m_isValid;
+ unsigned m_result;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698