Source/core/css/MediaQueryList.cpp - Issue 369423002: Have srcset respond to viewport changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryList.cpp

Issue 369423002: Have srcset respond to viewport changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryList.cpp

diff --git a/Source/core/css/MediaQueryList.cpp b/Source/core/css/MediaQueryList.cpp

index 70943e0a5c10d6f506881ca65ea02b4eac5b4325..b02f6d4093c873d9d977f4e64b36a909182eba98 100644

--- a/Source/core/css/MediaQueryList.cpp

+++ b/Source/core/css/MediaQueryList.cpp

@@ -37,6 +37,7 @@ MediaQueryList::MediaQueryList(PassRefPtrWillBeRawPtr<MediaQueryMatcher> matcher

, m_media(media)

, m_matchesDirty(true)

, m_matches(false)

+ , m_alwaysUpdate(false)

{

m_matcher->addMediaQueryList(this);

updateMatches();

@@ -99,7 +100,7 @@ void MediaQueryList::mediaFeaturesChanged(WillBeHeapVector<RefPtrWillBeMember<Me

bool MediaQueryList::updateMatches()

{

m_matchesDirty = false;

- if (m_matches != m_matcher->evaluate(m_media.get())) {

+ if (m_alwaysUpdate || m_matches != m_matcher->evaluate(m_media.get())) {

m_matches = !m_matches;

return true;

}