Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 369423002: Have srcset respond to viewport changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Self review nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/parser/HTMLPreloadScanner.cpp
diff --git a/Source/core/html/parser/HTMLPreloadScanner.cpp b/Source/core/html/parser/HTMLPreloadScanner.cpp
index 03d758daa34c9b747f93d7672e1446c740738227..85ac95291b324ea14919fcc202bbd0c3f05f89e1 100644
--- a/Source/core/html/parser/HTMLPreloadScanner.cpp
+++ b/Source/core/html/parser/HTMLPreloadScanner.cpp
@@ -116,8 +116,9 @@ public:
{
if (match(m_tagImpl, imgTag)
|| match(m_tagImpl, sourceTag)) {
+ bool viewportDependant;
if (RuntimeEnabledFeatures::pictureSizesEnabled())
- m_sourceSize = SizesAttributeParser::findEffectiveSize(String(), m_mediaValues);
+ m_sourceSize = SizesAttributeParser::findEffectiveSize(String(), m_mediaValues, viewportDependant);
return;
}
if ( !match(m_tagImpl, inputTag)
@@ -197,7 +198,8 @@ private:
m_srcsetImageCandidate = bestFitSourceForSrcsetAttribute(m_mediaValues->devicePixelRatio(), m_sourceSize, attributeValue);
setUrlToLoad(bestFitSourceForImageAttributes(m_mediaValues->devicePixelRatio(), m_sourceSize, m_imgSrcUrl, m_srcsetImageCandidate), AllowURLReplacement);
} else if (RuntimeEnabledFeatures::pictureSizesEnabled() && match(attributeName, sizesAttr) && !m_sourceSizeSet) {
- m_sourceSize = SizesAttributeParser::findEffectiveSize(attributeValue, m_mediaValues);
+ bool viewportDependant;
+ m_sourceSize = SizesAttributeParser::findEffectiveSize(attributeValue, m_mediaValues, viewportDependant);
m_sourceSizeSet = true;
if (!m_srcsetImageCandidate.isEmpty()) {
m_srcsetImageCandidate = bestFitSourceForSrcsetAttribute(m_mediaValues->devicePixelRatio(), m_sourceSize, m_srcsetAttributeValue);
@@ -239,7 +241,8 @@ private:
m_srcsetAttributeValue = attributeValue;
m_srcsetImageCandidate = bestFitSourceForSrcsetAttribute(m_mediaValues->devicePixelRatio(), m_sourceSize, attributeValue);
} else if (match(attributeName, sizesAttr) && !m_sourceSizeSet) {
- m_sourceSize = SizesAttributeParser::findEffectiveSize(attributeValue, m_mediaValues);
+ bool viewportDependant;
+ m_sourceSize = SizesAttributeParser::findEffectiveSize(attributeValue, m_mediaValues, viewportDependant);
m_sourceSizeSet = true;
if (!m_srcsetImageCandidate.isEmpty()) {
m_srcsetImageCandidate = bestFitSourceForSrcsetAttribute(m_mediaValues->devicePixelRatio(), m_sourceSize, m_srcsetAttributeValue);

Powered by Google App Engine
This is Rietveld 408576698