Have srcset respond to viewport changes

Source/core/css/parser/SizesAttributeParser.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/css/parser/SizesAttributeParser.h"
 
 #include "core/MediaTypeNames.h"
 #include "core/css/MediaQueryEvaluator.h"
 #include "core/css/parser/MediaQueryTokenizer.h"
 #include "core/css/parser/SizesCalcParser.h"
 
 namespace WebCore {
 
-unsigned SizesAttributeParser::findEffectiveSize(const String& attribute, PassRefPtr<MediaValues> mediaValues)
+unsigned SizesAttributeParser::findEffectiveSize(const String& attribute, PassRefPtr<MediaValues> mediaValues, bool& viewportDependant)
 {
     Vector<MediaQueryToken> tokens;
+    unsigned size;
     SizesAttributeParser parser(mediaValues);
 
     MediaQueryTokenizer::tokenize(attribute, tokens);
-    if (!parser.parse(tokens))
-        return parser.effectiveSizeDefaultValue();
-    return parser.effectiveSize();
+    if (parser.parse(tokens))
+        size = parser.effectiveSize();
+    else
+        size = parser.effectiveSizeDefaultValue();
+    viewportDependant = parser.viewportDependant();

[esprehn, 2014/07/14 08:39:49]

You should hide this logic inside an instance method.

SizesAttributeParser parser(attribute, mediaValues);
parser.parse();
if (parser.viewportDependant()) {
  ...
}

+    return size;
 }
 
 bool SizesAttributeParser::calculateLengthInPixels(MediaQueryTokenIterator startToken, MediaQueryTokenIterator endToken, unsigned& result)
 {
     if (startToken == endToken)
         return false;
     MediaQueryTokenType type = startToken->type();
     if (type == DimensionToken) {
         int length;
         if (!CSSPrimitiveValue::isLength(startToken->unitType()))
             return false;
+        m_viewportDependant = CSSPrimitiveValue::isViewportPercentageLength(startToken->unitType());
         if ((m_mediaValues->computeLength(startToken->numericValue(), startToken->unitType(), length)) && (length > 0)) {
             result = (unsigned)length;
             return true;
         }
     } else if (type == FunctionToken) {
-        return SizesCalcParser::parse(startToken, endToken, m_mediaValues, result);
+        return SizesCalcParser::parse(startToken, endToken, m_mediaValues, result, m_viewportDependant);
     } else if (type == NumberToken && !startToken->numericValue()) {
         result = 0;
         return true;
     }
 
     return false;
 }
 
 static void reverseSkipIrrelevantTokens(MediaQueryTokenIterator& token, MediaQueryTokenIterator startToken)
 {
@@ skipping 75 matching lines @@
 
 unsigned SizesAttributeParser::effectiveSize()
 {
     if (m_lengthWasSet)
         return m_length;
     return effectiveSizeDefaultValue();
 }
 
 unsigned SizesAttributeParser::effectiveSizeDefaultValue()
 {
-    // Returning the equivalent of "100%"
+    // Returning the equivalent of "100vw"
+    m_viewportDependant = true;
     return m_mediaValues->viewportWidth();
 }
 
 } // namespace