Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 369353002: Create a FakeAccountReconcilor that doesn't perform network requests (Closed)

Created:
6 years, 5 months ago by Mike Lerman
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Create a FakeAccountReconcilor that doesn't perform network requests BUG=381866 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -7 lines) Patch
M chrome/browser/extensions/api/identity/identity_apitest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/signin/fake_account_reconcilor.h View 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/signin/fake_account_reconcilor.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.h View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Lerman
Hi reviewers, PTAL. Thanks, Mike
6 years, 5 months ago (2014-07-08 15:49:13 UTC) #1
Andrew T Wilson (Slow)
LGTM. Ideally Roger would be around to review this since he knows the acct reconcilor ...
6 years, 5 months ago (2014-07-09 13:43:21 UTC) #2
Mike Lerman
On 2014/07/09 13:43:21, Andrew T Wilson wrote: > LGTM. Ideally Roger would be around to ...
6 years, 5 months ago (2014-07-09 13:44:49 UTC) #3
Michael Courage
lgtm
6 years, 5 months ago (2014-07-09 16:58:09 UTC) #4
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 5 months ago (2014-07-09 17:09:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/369353002/70001
6 years, 5 months ago (2014-07-09 17:11:26 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 20:47:41 UTC) #7
Message was sent while issue was closed.
Change committed as 282116

Powered by Google App Engine
This is Rietveld 408576698