Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 369333002: DevTools: Added error message when the command is invoked from the console with exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@add-evaluate-exception-details

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InjectedScriptBase.cpp ('K') | « Source/devtools/front_end/console/ConsoleView.js ('k') | Source/devtools/front_end/sdk/ConsoleModel.js » ('j') | Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js

index 24c80f8ec256ded1f84af0c6bbd3a52df0174013..3f07de9f812a756dd337a7543305a141eaf1f313 100644

--- a/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -344,7 +344,7 @@ WebInspector.ConsoleViewMessage.prototype = {

}

// There can be string log and string eval result. We distinguish between them based on message type.

- var shouldFormatMessage = WebInspector.RemoteObject.type(parameters[0]) === "string" && this._message.type !== WebInspector.ConsoleMessage.MessageType.Result;

+ var shouldFormatMessage = WebInspector.RemoteObject.type(parameters[0]) === "string" && (this._message.type !== WebInspector.ConsoleMessage.MessageType.Result || this._message.level === WebInspector.ConsoleMessage.MessageLevel.Error);

// Multiple parameters with the first being a format string. Save unused substitutions.

if (shouldFormatMessage) {