DevTools: Added error message when the command is invoked from the console with exception

Source/devtools/front_end/console/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 759 matching lines @@
         var str = this._prompt.text;
         if (!str.length)
             return;
         this._appendCommand(str, true);
     },
 
     /**
      * @param {?WebInspector.RemoteObject} result
      * @param {boolean} wasThrown
      * @param {!WebInspector.ConsoleMessage} originatingConsoleMessage
+     * @param {?DebuggerAgent.ExceptionDetails=} exceptionDetails
      */
-    _printResult: function(result, wasThrown, originatingConsoleMessage)
+    _printResult: function(result, wasThrown, originatingConsoleMessage, exceptionDetails)
     {
         if (!result)
             return;
 
         var target = result.target();
         /**
          * @param {string=} url
          * @param {number=} lineNumber
          * @param {number=} columnNumber
          */
         function addMessage(url, lineNumber, columnNumber)
         {
             var level = wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log;
-            var message = new WebInspector.ConsoleMessage(target, WebInspector.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, [result]);
+            var message;
+            if (!wasThrown)
+                message = new WebInspector.ConsoleMessage(target, WebInspector.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.MessageType.Result, url, lineNumber, columnNumber, undefined, [result]);
+            else
+                message = new WebInspector.ConsoleMessage(target, WebInspector.ConsoleMessage.MessageSource.JS, level, exceptionDetails.text, undefined, exceptionDetails.url, exceptionDetails.line, exceptionDetails.column, undefined, undefined, exceptionDetails.stackTrace);

[vsevik, 2014/07/15 16:14:33]

It would be better if we show both the resulting object and the stack trace in
case of exception.

[vsevik, 2014/07/15 16:14:33]

It would be better if we show both the resulting object and the stack trace in
case of exception.

[kozyatinskiy1, 2014/07/16 13:15:47]

Done.

             message.setOriginatingMessage(originatingConsoleMessage);
             target.consoleModel.addMessage(message);
         }
 
         if (result.type !== "function") {
             addMessage();
             return;
         }
 
         result.functionDetails(didGetDetails);
@@ skipping 36 matching lines @@
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _commandEvaluated: function(event)
     {
         var data = /**{{result: ?WebInspector.RemoteObject, wasThrown: boolean, text: string, commandMessage: !WebInspector.ConsoleMessage}} */ (event.data);
         this._prompt.pushHistoryItem(data.text);
         WebInspector.settings.consoleHistory.set(this._prompt.historyData.slice(-30));
-        this._printResult(data.result, data.wasThrown, data.commandMessage);
+        this._printResult(data.result, data.wasThrown, data.commandMessage, data.exceptionDetails);
     },
 
     /**
      * @return {!Array.<!Element>}
      */
     elementsToRestoreScrollPositionsFor: function()
     {
         return [this._messagesElement];
     },
 
@@ skipping 354 matching lines @@
 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = {
     /**
      * @return {boolean}
      */
     handleAction: function()
     {
         WebInspector.consoleModel.show();
         return true;
     }
 }