All isolate tests running on vm

tests/isolate/mandel_isolate_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library MandelIsolateTest;
 import 'dart:async';
 import 'dart:isolate';
 import 'dart:math';
 import '../../pkg/unittest/lib/unittest.dart';
 
@@ skipping 19 matching lines @@
   MandelbrotState() {
     _result = new List<List<int>>(N);
     _lineProcessedBy = new List<LineProcessorClient>(N);
     _sent = 0;
     _missing = N;
     _validated = new Completer<bool>();
   }
 
   void startClient(int id) {
     assert(_sent < N);
-    final client = new LineProcessorClient(this, id);
-    client.processLine(_sent++);
+    int line = _sent++;
+    LineProcessorClient.create(this, id).then((final client) {
+      client.processLine(line);
+    });
   }
 
   void notifyProcessedLine(LineProcessorClient client, int y, List<int> line) {
     assert(_result[y] == null);
     _result[y] = line;
     _lineProcessedBy[y] = client;
 
     if (_sent != N) {
       client.processLine(_sent++);
     } else {
@@ skipping 27 matching lines @@
 
   List<List<int>> _result;
   List<LineProcessorClient> _lineProcessedBy;
   int _sent;
   int _missing;
   Completer<bool> _validated;
 }
 
 
 class LineProcessorClient {
+  MandelbrotState _state;
+  int _id;
+  SendPort _port;
 
-  LineProcessorClient(MandelbrotState this._state, int this._id) {
-    _port = spawnFunction(processLines);
+  LineProcessorClient(this._state, this._id, this._port);
+
+  static Future<LineProcessorClient> create(MandebrotState state, int id) {
+    ReceivePort reply = new ReceivePort();
+    Future isolateStart = Isolate.spawn(processLines, reply.sendPort);

[floitsch, 2013/10/23 13:33:24]

No need for temporary variable.

Isolate.spawn(processLines, reply.sendPort)
  .then((_) => reply.first)
  .then((port) => new LineProcessorClient(state, id, port));

[Lasse Reichstein Nielsen, 2013/10/24 10:26:01]

I just thought the line-breaks looked better this way.
It looks artificial to split up reply.first.then by returning reply.first.

I've tried a different rewrite.

+    return isolateStart.then((_) =>
+        reply.first.then((port) => new LineProcessorClient(state, id, port)));
   }
 
   void processLine(int y) {
-    _port.call(y).then((List<int> message) {
+    ReceivePort reply = new ReceivePort();
+    reply.first.then((List<int> message) {
       _state.notifyProcessedLine(this, y, message);
     });
+    _port.send([y, reply.sendPort]);

[floitsch, 2013/10/23 13:33:24]

I prefer the "right" order.

ReceivePort reply = ...
_port.send([y, reply.sendPort]);
reply.first.then(...)

[Lasse Reichstein Nielsen, 2013/10/24 10:26:01]

I actually consider that the wrong order.
The safest order should be:
- Create port 
- set up listeners on port 
- reveal port to someone else.

Revealing the port before setting up the listeners will work because the stream
is buffering, but it still feels a little wrong.

I can understand the send-request/handle-reply sequencing as well, and I've not
been consistent since both versions work, so I'll change it.

   }
 
   void shutdown() {
-    _port.send(TERMINATION_MESSAGE, null);
+    _port.send(TERMINATION_MESSAGE);
   }
-
-  MandelbrotState _state;
-  int _id;
-  SendPort _port;
 }
 
 List<int> processLine(int y) {
   double inverseN = 2.0 / N;
   double Civ = y * inverseN - 1.0;
   List<int> result = new List<int>(N);
   for (int x = 0; x < N; x++) {
     double Crv = x * inverseN - 1.5;
 
     double Zrv = Crv;
     double Ziv = Civ;
 
     double Trv = Crv * Crv;
     double Tiv = Civ * Civ;
 
     int i = 49;
     do {
       Ziv = (Zrv * Ziv) + (Zrv * Ziv) + Civ;
       Zrv = Trv - Tiv + Crv;
 
       Trv = Zrv * Zrv;
       Tiv = Ziv * Ziv;
     } while (((Trv + Tiv) <= 4.0) && (--i > 0));
 
     result[x] = i;
   }
   return result;
 }
 
-void processLines() {
-  port.receive((message, SendPort replyTo) {
-    if (message == TERMINATION_MESSAGE) {
-      assert(replyTo == null);
+void processLines(SendPort replyPort) {
+  ReceivePort port = new ReceivePort();
+  port.listen((message) {
+    if (message != TERMINATION_MESSAGE) {
+      int line = message[0];
+      SendPort replyTo = message[1];
+      replyTo.send(processLine(line));
+    } else {
       port.close();
-    } else {
-      replyTo.send(processLine(message), null);
     }
   });
+  replyPort.send(port.sendPort);
 }