All isolate tests running on vm

tests/isolate/illegal_msg_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library illegal_msg_tests;
 import "package:expect/expect.dart";
 import 'dart:isolate';
 import "package:async_helper/async_helper.dart";
 
 funcFoo(x) => x + 2;
 
-echo() {
-  port.receive((msg, reply) {
-    reply.send("echoing ${msg(1)}}");
+echo(sendPort) {
+  var port = new ReceivePort();
+  sendPort.send(port.sendPort);
+  port.list((msg) {

[Lasse Reichstein Nielsen, 2013/10/24 10:26:01]

This is a typo, so this code doesn't run either (which is expected, sending the
message should fail in "snd.send" below, so we never reach the isolate).

+    sendPort.send("echoing ${msg(1)}}");
   });
 }
 
 main() {
-  var snd = spawnFunction(echo);
+  ReceivePort port = new ReceivePort();
+  Future spawn = Isolate.spawn(echo, port.sendPort);
   var caught_exception = false;
-  try {
-    snd.send(funcFoo, port.toSendPort());
-  } catch (e) {
-    caught_exception = true;
-  }
+  var stream = port.asBroadcastStream();
+  asyncStart();
+  stream.first.then((snd) {
+    asyncEnd();

[floitsch, 2013/10/23 13:33:24]

Looks like the second part is never executed.

[Lasse Reichstein Nielsen, 2013/10/24 10:26:01]

It never is if the test succeeds. The expected behavior is to catch the
exception. Only if we successfully sends the bad message will the isolate be
used at all, ditto the else-branch below.

Moved asyncEnd to end of function, so async ranges overlap.

+    try {
+      snd.send(funcFoo);
+    } catch (e) {
+      caught_exception = true;
+    }
 
-  if (caught_exception) {
-    port.close();
-  } else {
-    asyncStart();
-    port.receive((msg, reply) {
-      print("from worker ${msg}");
-      asyncEnd();
-    });
-  }
-  Expect.isTrue(caught_exception);
+    if (caught_exception) {
+      port.close();
+    } else {
+      asyncStart();

[floitsch, 2013/10/23 13:33:24]

This would yield an error.
you are not allowed to do:
start, end, start end.
they must overlap.

[Lasse Reichstein Nielsen, 2013/10/24 10:26:01]

Now overlaps.

+      stream.first.then((msg) {
+        print("from worker ${msg}");
+        asyncEnd();
+      });
+    }
+    Expect.isTrue(caught_exception);
+  });
 }