Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 369323002: Add WebView Telemetry Bot Gyp Flag (Closed)

Created:
6 years, 5 months ago by hjd
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add WebView Telemetry Bot Gyp Flag The WebView Telemetry will build in the Chromium tree but needs a few things turned off namely jarjar and the ICU data file. BUG=391488 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283363

Patch Set 1 #

Patch Set 2 : Fix condition. #

Patch Set 3 : Adding missing gpy lines for scoping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/common.gypi View 1 2 5 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hjd
ptal
6 years, 5 months ago (2014-07-04 16:54:28 UTC) #1
mkosiba (inactive)
lgtm
6 years, 5 months ago (2014-07-07 16:08:37 UTC) #2
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 5 months ago (2014-07-14 23:38:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/369323002/2
6 years, 5 months ago (2014-07-14 23:40:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 11:43:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 11:45:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28741)
6 years, 5 months ago (2014-07-15 11:45:46 UTC) #7
hjd
The CQ bit was checked by hjd@chromium.org
6 years, 5 months ago (2014-07-15 21:28:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/369323002/30001
6 years, 5 months ago (2014-07-15 21:32:33 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:46:30 UTC) #10
Message was sent while issue was closed.
Change committed as 283363

Powered by Google App Engine
This is Rietveld 408576698