Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 369313002: m_parsedCalculation has to be cleared between parsing cubic-bezier() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test update Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/css/cubic-bezier-with-multiple-calcs-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 3102 matching lines...) Expand 10 before | Expand all | Expand 10 after
3113 } 3113 }
3114 value3 = cssValuePool().createImplicitInitialValue(); 3114 value3 = cssValuePool().createImplicitInitialValue();
3115 return true; 3115 return true;
3116 } 3116 }
3117 3117
3118 bool CSSPropertyParser::parseCubicBezierTimingFunctionValue(CSSParserValueList*& args, double& result) 3118 bool CSSPropertyParser::parseCubicBezierTimingFunctionValue(CSSParserValueList*& args, double& result)
3119 { 3119 {
3120 CSSParserValue* v = args->current(); 3120 CSSParserValue* v = args->current();
3121 if (!validUnit(v, FNumber)) 3121 if (!validUnit(v, FNumber))
3122 return false; 3122 return false;
3123 result = v->fValue; 3123 result = parsedDouble(v, ReleaseParsedCalcValue);
3124 v = args->next(); 3124 v = args->next();
3125 if (!v) 3125 if (!v)
3126 // The last number in the function has no comma after it, so we're done. 3126 // The last number in the function has no comma after it, so we're done.
3127 return true; 3127 return true;
3128 if (!isComma(v)) 3128 if (!isComma(v))
3129 return false; 3129 return false;
3130 args->next(); 3130 args->next();
3131 return true; 3131 return true;
3132 } 3132 }
3133 3133
(...skipping 5371 matching lines...) Expand 10 before | Expand all | Expand 10 after
8505 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill)); 8505 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
8506 if (!seenStroke) 8506 if (!seenStroke)
8507 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) ); 8507 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) );
8508 if (!seenMarkers) 8508 if (!seenMarkers)
8509 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers )); 8509 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers ));
8510 8510
8511 return parsedValues.release(); 8511 return parsedValues.release();
8512 } 8512 }
8513 8513
8514 } // namespace blink 8514 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/fast/css/cubic-bezier-with-multiple-calcs-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698