Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 369313002: m_parsedCalculation has to be cleared between parsing cubic-bezier() (Closed)

Created:
6 years, 5 months ago by reni
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Mike Lawther (Google)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fixing calc() parameter parsing in cubic-bezier functions Before this patch, calc values in cubic-bezier functions weren't being read correctly since they were handled as simple floats. R=rob.buis@samsung.com,timloh@chromium.org,alancutter@chromium.org BUG=388332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178998

Patch Set 1 #

Patch Set 2 : Updated patch #

Patch Set 3 : Test update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
A LayoutTests/fast/css/cubic-bezier-with-multiple-calcs-crash.html View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/cubic-bezier-with-multiple-calcs-crash-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
reni
6 years, 5 months ago (2014-07-04 17:07:58 UTC) #1
alancutter (OOO until 2018)
This fixes the assertion failure but does not fix the bug in the code. If ...
6 years, 5 months ago (2014-07-07 00:25:27 UTC) #2
reni
@alancutter: thanks for the review! The patch is updated according to your suggestion.
6 years, 5 months ago (2014-07-21 13:22:26 UTC) #3
alancutter (OOO until 2018)
Much better, lgtm. :) The title and description could be updated to state that the ...
6 years, 5 months ago (2014-07-22 05:14:34 UTC) #4
reni
The test case is updated. @alancutter, @timloh: ping me please if I can commit.
6 years, 5 months ago (2014-07-25 12:25:42 UTC) #5
Timothy Loh
On 2014/07/25 12:25:42, reni wrote: > The test case is updated. > @alancutter, @timloh: ping ...
6 years, 4 months ago (2014-07-28 00:27:18 UTC) #6
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 4 months ago (2014-07-28 00:27:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/369313002/40001
6 years, 4 months ago (2014-07-28 00:28:58 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 01:32:23 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 02:29:58 UTC) #10
Message was sent while issue was closed.
Change committed as 178998

Powered by Google App Engine
This is Rietveld 408576698