Issue 369303004: Pass() type followups after https://codereview.chromium.org/367403002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369303004: Pass() type followups after https://codereview.chromium.org/367403002/ (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Joao da Silva

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Pass() type followups after https://codereview.chromium.org/367403002/ DeepCopy() has a covariant return type, so its result needs to be explicitly cast to base::Value. Use an explicit call to scoped_ptr<base::Value> instead of make_scoped_ptr(...).PassAs<base::Value> in a few other places too, as that seems a bit simpler. BUG=82385 TBR=joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281443

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -37 lines)			Patch
	M	components/policy/core/common/registry_dict_win.cc	View		5 chunks	+12 lines, -12 lines	0 comments	Download
	M	components/policy/core/common/registry_dict_win_unittest.cc	View	1	10 chunks	+25 lines, -25 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/369303004/1

6 years, 5 months ago (2014-07-04 21:35:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/369303004/20001

6 years, 5 months ago (2014-07-04 21:47:32 UTC) #5

Nico

Committed patchset #2 manually as r281443 (presubmit successful).

6 years, 5 months ago (2014-07-04 22:02:32 UTC) #6

Message was sent while issue was closed.

lgtm