Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 369303003: Fix linking error in message_center (Closed)

Created:
6 years, 5 months ago by Tomasz Moniuszko
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Elliot Glaysher
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix linking error in message_center Fixup to 3e28d46ea1840c9d4dc451271dd7e6d3b510fc50 message_center now depends on aura even if 'use_ash=0'. BUG=375466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/message_center/message_center.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Tomasz Moniuszko
6 years, 5 months ago (2014-07-04 15:22:08 UTC) #1
dewittj
On 2014/07/04 15:22:08, Tomasz Moniuszko wrote: Lgtm thanks
6 years, 5 months ago (2014-07-04 16:12:17 UTC) #2
Tomasz Moniuszko
The CQ bit was checked by tmoniuszko@opera.com
6 years, 5 months ago (2014-07-07 06:58:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/369303003/1
6 years, 5 months ago (2014-07-07 06:59:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 09:11:23 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 10:21:40 UTC) #6
Message was sent while issue was closed.
Change committed as 281516

Powered by Google App Engine
This is Rietveld 408576698