Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 36913002: test.py: Sending JSON between test_controller.js <-> browser_controller (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index 4a043ddd8f0a621e64e1c38727c8f3ca77e6fafd..847febf711db85998195fa2a90ac960c81bbd604 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -1996,6 +1996,8 @@ class SummaryReport {
static int compileErrorSkip = 0;
static void add(Set<Expectation> expectations) {
+ bool containsFail = expectations.any(
+ (expectation) => expectation.canBeOutcomeOf(Expectation.FAIL));
++total;
if (expectations.contains(Expectation.SKIP)) {
++skipped;
@@ -2004,7 +2006,7 @@ class SummaryReport {
++skippedByDesign;
} else {
if (expectations.contains(Expectation.PASS) &&
Bill Hesse 2013/11/15 11:24:03 Comment "Counts the flaky tests"
kustermann 2013/11/19 10:06:10 I'll do it in another CL.
- expectations.contains(Expectation.FAIL) &&
+ containsFail &&
!expectations.contains(Expectation.CRASH) &&
!expectations.contains(Expectation.OK)) {
++noCrash;
@@ -2016,7 +2018,7 @@ class SummaryReport {
expectations.length == 2) {
++failOk;
}
- if (expectations.contains(Expectation.FAIL) && expectations.length == 1) {
+ if (containsFail && expectations.length == 1) {
++fail;
}
if (expectations.contains(Expectation.CRASH) &&

Powered by Google App Engine
This is Rietveld 408576698