Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: dart/tools/testing/dart/browser_controller.dart

Issue 36913002: test.py: Sending JSON between test_controller.js <-> browser_controller (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tools/testing/dart/browser_controller.dart
diff --git a/dart/tools/testing/dart/browser_controller.dart b/dart/tools/testing/dart/browser_controller.dart
index 4010c028aaa5078d22f5f94afae4f5e665f89da0..c18033e859516d231839b24694a83058c67fabb9 100644
--- a/dart/tools/testing/dart/browser_controller.dart
+++ b/dart/tools/testing/dart/browser_controller.dart
@@ -673,14 +673,16 @@ class BrowserTest {
/* Describes the output of running the test in a browser */
class BrowserTestOutput {
- final bool didTimeout;
final Duration delayUntilTestStarted;
final Duration duration;
+
+ final String lastKnownMessage;
Bill Hesse 2013/11/15 11:24:03 Comment here on format (JSON?)
kustermann 2013/11/19 10:06:10 It's not necessarily JSON, it's whatever we got fr
+
final BrowserOutput browserOutput;
- final String dom;
+ final bool didTimeout;
BrowserTestOutput(
- this.delayUntilTestStarted, this.duration, this.dom,
+ this.delayUntilTestStarted, this.duration, this.lastKnownMessage,
this.browserOutput, {this.didTimeout: false});
}

Powered by Google App Engine
This is Rietveld 408576698