Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: dart/pkg/unittest/lib/unittest.dart

Issue 36913002: test.py: Sending JSON between test_controller.js <-> browser_controller (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/unittest/lib/unittest.dart
diff --git a/dart/pkg/unittest/lib/unittest.dart b/dart/pkg/unittest/lib/unittest.dart
index 41bfc92386678f3f57c41754a520c4bd13150805..5a757c38293d3c2621a9fd40c391219f8fb24a96 100644
--- a/dart/pkg/unittest/lib/unittest.dart
+++ b/dart/pkg/unittest/lib/unittest.dart
@@ -779,8 +779,7 @@ void _completeTests() {
}
}
_config.onSummary(passed, failed, errors, testCases, _uncaughtErrorMessage);
- _config.onDone(passed > 0 && failed == 0 && errors == 0 &&
kustermann 2013/11/14 13:43:31 If there are 0 tests to be executed, the result is
- _uncaughtErrorMessage == null);
+ _config.onDone(failed == 0 && errors == 0 && _uncaughtErrorMessage == null);
ricow1 2013/11/14 14:42:27 I am unsure if we have other assumptions about thi
_initialized = false;
}

Powered by Google App Engine
This is Rietveld 408576698