Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 36913002: test.py: Sending JSON between test_controller.js <-> browser_controller (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index d62a33e90ed14e166a58d4c18a3892edb397e15f..f13c00660978a9e78a496058b2a0d87fc93a6710 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -1994,6 +1994,8 @@ class SummaryReport {
static int compileErrorSkip = 0;
static void add(Set<Expectation> expectations) {
+ bool containsFail = expectations.any(
+ (expectation) => expectation.canBeOutcomeOf(Expectation.FAIL));
++total;
if (expectations.contains(Expectation.SKIP)) {
++skipped;
@@ -2002,7 +2004,7 @@ class SummaryReport {
++skippedByDesign;
} else {
if (expectations.contains(Expectation.PASS) &&
- expectations.contains(Expectation.FAIL) &&
+ containsFail &&
!expectations.contains(Expectation.CRASH) &&
!expectations.contains(Expectation.OK)) {
++noCrash;
@@ -2014,7 +2016,7 @@ class SummaryReport {
expectations.length == 2) {
++failOk;
}
- if (expectations.contains(Expectation.FAIL) && expectations.length == 1) {
+ if (containsFail && expectations.length == 1) {
++fail;
}
if (expectations.contains(Expectation.CRASH) &&
« dart/tools/testing/dart/test_runner.dart ('K') | « dart/tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698