Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: BUILD.gn

Issue 369073002: Don't even include v8.h from libbase or libplatform (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8-platform.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 02919edf67fe06dcb8bfba5cc960acbbe1dce274..5066ce18078123ee38eeb779bffb7caf4614f680 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -37,6 +37,12 @@ config("internal_config") {
}
}
+config("internal_config_base") {
+ visibility = ":*" # Only targets in this file can depend on this.
+
+ include_dirs = [ "." ]
+}
+
# This config should only be applied to code using V8 and not any V8 code
# itself.
config("external_config") {
@@ -1014,7 +1020,7 @@ source_set("v8_libbase") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [ ":internal_config", ":features", ":toolchain" ]
+ configs += [ ":internal_config_base", ":features", ":toolchain" ]
defines = []
@@ -1077,7 +1083,7 @@ source_set("v8_libplatform") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [ ":internal_config", ":features", ":toolchain" ]
+ configs += [ ":internal_config_base", ":features", ":toolchain" ]
deps = [
":v8_libbase",
« no previous file with comments | « no previous file | include/v8-platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698