Issue 369073002: Don't even include v8.h from libbase or libplatform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369073002: Don't even include v8.h from libbase or libplatform (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Don't even include v8.h from libbase or libplatform BUG=none R=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22182

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -23 lines)			Patch
M	BUILD.gn	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	include/v8-platform.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/base/DEPS	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/base/atomicops.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libplatform/DEPS	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	3 chunks	+0 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-07-03 08:51:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22182 (presubmit successful).