content/browser/service_worker/service_worker_context_request_handler.cc - Issue 369063004: ServiceWorker: SWRegisterJob should manage status of SWVersion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.cc

Issue 369063004: ServiceWorker: SWRegisterJob should manage status of SWVersion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_handle_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc

index cb4b1e38270ac3f8500858fd16c4758d9ea1f7d6..b1a017a81b880fd1f18961f0ae7a1ab5e889ebda 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler.cc

@@ -75,8 +75,10 @@ net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJob(

bool ServiceWorkerContextRequestHandler::ShouldAddToScriptCache(

const GURL& url) {

// We only write imports that occur during the initial eval.

- if (version_->status() != ServiceWorkerVersion::NEW)

+ if (version_->status() != ServiceWorkerVersion::NEW &&

+ version_->status() != ServiceWorkerVersion::INSTALLING) {

return false;

+ }

return version_->script_cache_map()->Lookup(url) ==

kInvalidServiceWorkerResponseId;

}