Source/platform/graphics/gpu/DrawingBuffer.cpp - Issue 369043003: Let canvas decide how to handle the case of resource lost reported by client: 2D part

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/gpu/DrawingBuffer.cpp

Issue 369043003: Let canvas decide how to handle the case of resource lost reported by client: 2D part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add default parameter value for mailboxReleased interface Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/Canvas2DLayerBridge.cpp ('K') | « Source/platform/graphics/gpu/DrawingBuffer.h ('k') | Source/platform/graphics/gpu/DrawingBufferTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/gpu/DrawingBuffer.cpp

diff --git a/Source/platform/graphics/gpu/DrawingBuffer.cpp b/Source/platform/graphics/gpu/DrawingBuffer.cpp

index 0ec4bf9179012c1217b92aa3362f4f7d02e1e9df..2f6340ba22f2cdff9e74c9f816d4963862855109 100644

--- a/Source/platform/graphics/gpu/DrawingBuffer.cpp

+++ b/Source/platform/graphics/gpu/DrawingBuffer.cpp

@@ -276,9 +276,9 @@ bool DrawingBuffer::prepareMailbox(blink::WebExternalTextureMailbox* outMailbox,

return true;

}

-void DrawingBuffer::mailboxReleased(const blink::WebExternalTextureMailbox& mailbox)

+void DrawingBuffer::mailboxReleased(const blink::WebExternalTextureMailbox& mailbox, bool lostResource)

{

- if (m_destructionInProgress) {

+ if (m_destructionInProgress && !m_context->isContextLost()) {

mailboxReleasedWhileDestructionInProgress(mailbox);

return;

}

@@ -289,7 +289,8 @@ void DrawingBuffer::mailboxReleased(const blink::WebExternalTextureMailbox& mail

mailboxInfo->mailbox.syncPoint = mailbox.syncPoint;

ASSERT(mailboxInfo->m_parentDrawingBuffer.get() == this);

mailboxInfo->m_parentDrawingBuffer.clear();

- m_recycledMailboxQueue.prepend(mailboxInfo->mailbox);

+ if (!m_context->isContextLost())

+ m_recycledMailboxQueue.prepend(mailboxInfo->mailbox);

return;

}