Issue 369033002: Oilpan: Build fix after r177440

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 369033002: Oilpan: Build fix after r177440 (Closed)

Created:
6 years, 5 months ago by haraken

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, tkent, Yoav Weiss, esprehn, sof

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Build fix after r177440 TBR=tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177447

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	Source/core/html/HTMLSourceElement.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	Source/core/html/HTMLSourceElement.cpp	View		3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

Committed patchset #1 manually as r177447 (presubmit successful).

6 years, 5 months ago (2014-07-03 04:46:53 UTC) #2

sof

lgtm. (If https://codereview.chromium.org/287163010/ would have waited for an oilpan approval against its last patchset, some ...

6 years, 5 months ago (2014-07-03 05:33:13 UTC) #3

sof

On 2014/07/03 05:33:13, sof wrote: > lgtm. > > (If https://codereview.chromium.org/287163010/ would have waited for ...

6 years, 5 months ago (2014-07-03 06:00:02 UTC) #4

haraken

6 years, 5 months ago (2014-07-03 06:10:00 UTC) #5

Message was sent while issue was closed.

On 2014/07/03 06:00:02, sof wrote:
> On 2014/07/03 05:33:13, sof wrote:
> > lgtm.
> > 
> > (If https://codereview.chromium.org/287163010/ would have waited for an
oilpan
> > approval against its last patchset, some of this could have been avoided. Or
> at
> > least stood a better chance.)
> 
> (I'll Cc: oilpan-reviews on any drive-by-reviews from here on, to reduce
chances
> of details slipping past.)

Thanks, that's a good idea.

Expand Messages | Collapse Messages