Issue 36903002: StringToDouble code size optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 36903002: StringToDouble code size optimization. (Closed)

Created:
7 years, 2 months ago by Bangfu

Modified:
7 years, 1 month ago

Reviewers:
Benedikt Meurer, Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cast const char * to const uint8_t *, which removed a unnecessary version of InternalStringToDouble template. Code size (android arm build for d8): old d8: 17,479,047 bytes new d8: 17,445,492 bytes Total code size saved: 33,555 bytes R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17409

Patch Set 1 #

Patch Set 2 : Adjust code style. Add comments. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	src/conversions.cc	View	1	2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Looks OK. CC'ing sven/danno for additional feedback.

7 years, 1 month ago (2013-10-25 10:32:34 UTC) #1

Bangfu

On 2013/10/25 10:32:34, Benedikt Meurer wrote: > Looks OK. CC'ing sven/danno for additional feedback. Thank ...

7 years, 1 month ago (2013-10-28 09:21:03 UTC) #2

Benedikt Meurer

7 years, 1 month ago (2013-10-28 09:39:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17409 (presubmit successful).

Expand Messages | Collapse Messages