Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 369013002: ServiceWorker: Support navigator.serviceWorker.installing (Closed)

Created:
6 years, 5 months ago by nhiroki
Modified:
6 years, 5 months ago
Reviewers:
falken, michaeln, jschuh
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Support navigator.serviceWorker.installing This change plumbs '.installing' and you will be able to access an installing worker via 'navigator.serviceWorker.installing'. BUG=379012 TEST=content_unittest --gtest_filter=ServiceWorker* TEST=run_webkit_tests.py http/tests/serviceworker/installing.html (http://crrev.com/372453002) TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281931

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -5 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M content/child/service_worker/service_worker_provider_context.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/child/service_worker/service_worker_provider_context.cc View 4 chunks +24 lines, -3 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nhiroki
Ptal, thanks!
6 years, 5 months ago (2014-07-04 09:54:03 UTC) #1
falken
LGTM
6 years, 5 months ago (2014-07-07 01:35:02 UTC) #2
nhiroki
+tsepez@, could you review service_worker_messages.h ? Thanks.
6 years, 5 months ago (2014-07-08 06:39:11 UTC) #3
nhiroki
On 2014/07/08 06:39:11, nhiroki wrote: > +tsepez@, could you review service_worker_messages.h ? Thanks. Let me ...
6 years, 5 months ago (2014-07-08 07:22:50 UTC) #4
nhiroki
+jschuh@, could you review messages.h? Thanks.
6 years, 5 months ago (2014-07-08 07:25:20 UTC) #5
jschuh
ipc security lgtm (notes: browser -> renderer URLs and routing info).
6 years, 5 months ago (2014-07-08 16:24:40 UTC) #6
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 5 months ago (2014-07-08 21:14:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/369013002/240001
6 years, 5 months ago (2014-07-08 21:19:27 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:35:53 UTC) #9
Message was sent while issue was closed.
Change committed as 281931

Powered by Google App Engine
This is Rietveld 408576698