Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 369003002: Remove GpuHostMsg_UpdateVSyncParameters handler from GpuProcssHostUIShim (Closed)

Created:
6 years, 5 months ago by simonhong
Modified:
6 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, hyojun.im_lge.com
Project:
chromium
Visibility:
Public.

Description

Remove GpuHostMsg_UpdateVSyncParameters handler from GpuProcssHostUIShim After delegated frame is used, this message is not handled anymore by GpuProcessHostUIShim. On Aura, this message is handled by BrowserCompositorOutputSurfaceProxy. On Mac, vsync params updating is triggered not by gpu process but by browser process itself with DisplayLinkMac. On Android, browser process uses android system's vsync signal. R=ajuma@chromium.org, piman@chromium.org, kbr@chromium.org BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
simonhong
@ajuma, could you review this cl? You are the author of this message handler. Thanks!
6 years, 5 months ago (2014-07-03 01:01:21 UTC) #1
ajuma
On 2014/07/03 01:01:21, simonhong wrote: > @ajuma, could you review this cl? > You are ...
6 years, 5 months ago (2014-07-03 14:21:38 UTC) #2
simonhong
@kbr, I need owner's check. Thanks!
6 years, 5 months ago (2014-07-03 20:57:37 UTC) #3
piman
lgtm
6 years, 5 months ago (2014-07-07 18:04:32 UTC) #4
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 5 months ago (2014-07-07 19:22:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/369003002/1
6 years, 5 months ago (2014-07-07 19:23:46 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 22:30:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 22:54:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90283)
6 years, 5 months ago (2014-07-07 22:54:39 UTC) #9
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 5 months ago (2014-07-08 04:50:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/369003002/1
6 years, 5 months ago (2014-07-08 04:51:04 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 06:09:33 UTC) #12
Message was sent while issue was closed.
Change committed as 281674

Powered by Google App Engine
This is Rietveld 408576698