Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: content/common/frame_messages.h

Issue 368953006: Added the RenderView routing_id to the DidCommitProvisionalLoad message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added references to the bug tracking the RenderViewHost to RenderFrameHost migration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_scheduler_filter.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 1b83f26eabab76e1695a9dc870a8f7a2f260aae0..7a651efff601942d317e280592815401639e47ee 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -151,6 +151,16 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,
// Notifies the browser that for this navigation, the session history was
// successfully cleared.
IPC_STRUCT_MEMBER(bool, history_list_was_cleared)
+
+ // The routing_id of the render view associated with the navigation.
+ // We need to track the RenderViewHost routing_id because of downstream
+ // dependencies (crbug.com/392171 DownloadRequestHandle, SaveFileManager,
+ // ResourceDispatcherHostImpl, MediaStreamUIProxy,
+ // SpeechRecognitionDispatcherHost and possibly others). They look up the view
+ // based on the ID stored in the resource requests. Once those dependencies
+ // are unwound or moved to RenderFrameHost (crbug.com/304341) we can move the
+ // client to be based on the routing_id of the RenderFrameHost.
+ IPC_STRUCT_MEMBER(int, render_view_routing_id)
IPC_STRUCT_END()
IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
« no previous file with comments | « content/browser/loader/resource_scheduler_filter.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698