Issue 368903004: removing explicit enum numbering in ResourceScheduler::Client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 368903004: removing explicit enum numbering in ResourceScheduler::Client (Closed)

Created:
6 years, 5 months ago by aiolos (Not reviewing)

Modified:
6 years, 5 months ago

Reviewers:
mmenke

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

removing explicit enum numbering in ResourceScheduler::Client BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281898

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : nit #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	content/browser/loader/resource_scheduler.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

aiolos (Not reviewing)

The first CL hit some crashes of unittests when run locally, but they didn't appear ...

6 years, 5 months ago (2014-07-08 18:00:08 UTC) #1

mmenke

Thanks for doing this, LGTM! Just getting back to your other CL now. https://codereview.chromium.org/368903004/diff/20001/content/browser/loader/resource_scheduler.cc File ...

6 years, 5 months ago (2014-07-08 18:16:16 UTC) #2

aiolos (Not reviewing)

The CQ bit was checked by aiolos@chromium.org

6 years, 5 months ago (2014-07-08 20:17:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aiolos@chromium.org/368903004/40001

6 years, 5 months ago (2014-07-08 20:18:37 UTC) #4

Message was sent while issue was closed.

Change committed as 281898

Expand Messages | Collapse Messages