Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 368883003: cc: Disallow scroll offset animations when impl-scrolling isn't supported (Closed)

Created:
6 years, 5 months ago by ajuma
Modified:
6 years, 5 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Disallow scroll offset animations when impl-scrolling isn't supported SingleThreadProxy doesn't support directly changing scroll offsets on the impl layer tree (since it doesn't send scroll deltas from the impl side back to the main-thread side). This means that scroll offset animations should be disallowed by cc when using SingleThreadProxy. BUG=243871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281140

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M cc/animation/animation_registrar.h View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/animation/animation_registrar.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ajuma
6 years, 5 months ago (2014-07-02 20:37:39 UTC) #1
Ian Vollick
On 2014/07/02 20:37:39, ajuma wrote: lgtm!
6 years, 5 months ago (2014-07-02 20:48:16 UTC) #2
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 5 months ago (2014-07-02 20:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/368883003/20001
6 years, 5 months ago (2014-07-02 20:51:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 23:29:55 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 03:03:14 UTC) #6
Message was sent while issue was closed.
Change committed as 281140

Powered by Google App Engine
This is Rietveld 408576698