Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 368853003: Remove special ExecutableAccessorInfo handling based on flag (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
mvstanton, rafaelw
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove special ExecutableAccessorInfo handling based on flag This additionally removes special "prototype" handling for O.o, since it's broken; and added test. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22171

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -50 lines) Patch
M src/objects.h View 2 chunks +1 line, -9 lines 0 comments Download
M src/objects.cc View 5 chunks +23 lines, -30 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL mvstanton FYI rafaelw
6 years, 5 months ago (2014-07-02 12:04:35 UTC) #1
mvstanton
Nice cleanup/fix! lgtm.
6 years, 5 months ago (2014-07-02 12:15:48 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-02 15:28:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698