--trace-ic: much faster and available in Release mode.

--trace-ic: much faster and available in Release mode.

Also add IC tracing to a path where it was missing.

R=jarin@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22268

[Jakob Kummerow, 2014-07-03 16:23:42]

PTAL.

[Jakob Kummerow, 2014-07-07 13:34:03]

I meant to add some background here: the key idea of this CL is to avoid
creating a StackFrameIterator, because that's very slow. As a consequence, we
lose the ability to call JavaScriptFrame::PrintTop, so that function's
functionality must be implemented directly.

[Sven Panne, 2014-07-08 06:37:11]

DBC

https://codereview.chromium.org/368833003/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/368833003/diff/1/src/ic.cc#newcode73
src/ic.cc:73: // TODO(jkummerow): Add support for "apply". The logic is roughly:
Hmmm, can we extract the body of the while loop in JavaScriptFrame::PrintTop and
use it here instead of copying >30 lines of highly non-trivial code? As it is,
this is extremely ugly and guaranteed to diverge/break at some point.

[Jarin, 2014-07-08 07:44:36]

On 2014/07/08 06:37:11, Sven Panne wrote:
> DBC
> 
> https://codereview.chromium.org/368833003/diff/1/src/ic.cc
> File src/ic.cc (right):
> 
> https://codereview.chromium.org/368833003/diff/1/src/ic.cc#newcode73
> src/ic.cc:73: // TODO(jkummerow): Add support for "apply". The logic is
roughly:
> Hmmm, can we extract the body of the while loop in JavaScriptFrame::PrintTop
and
> use it here instead of copying >30 lines of highly non-trivial code? As it is,
> this is extremely ugly and guaranteed to diverge/break at some point.

+1

lgtm, otherwise.

[Jakob Kummerow, 2014-07-08 07:47:40]

Your wish is my command.

https://codereview.chromium.org/368833003/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/368833003/diff/1/src/ic.cc#newcode73
src/ic.cc:73: // TODO(jkummerow): Add support for "apply". The logic is roughly:
On 2014/07/08 06:37:11, Sven Panne wrote:
> Hmmm, can we extract the body of the while loop in JavaScriptFrame::PrintTop
and
> use it here instead of copying >30 lines of highly non-trivial code? As it is,
> this is extremely ugly and guaranteed to diverge/break at some point.

Done.

[Jarin, 2014-07-08 07:49:51]

On 2014/07/08 07:47:40, Jakob wrote:
> Your wish is my command.
> 
> https://codereview.chromium.org/368833003/diff/1/src/ic.cc
> File src/ic.cc (right):
> 
> https://codereview.chromium.org/368833003/diff/1/src/ic.cc#newcode73
> src/ic.cc:73: // TODO(jkummerow): Add support for "apply". The logic is
roughly:
> On 2014/07/08 06:37:11, Sven Panne wrote:
> > Hmmm, can we extract the body of the while loop in JavaScriptFrame::PrintTop
> and
> > use it here instead of copying >30 lines of highly non-trivial code? As it
is,
> > this is extremely ugly and guaranteed to diverge/break at some point.
> 
> Done.

Much better. Thanks!

[Jakob Kummerow, 2014-07-08 08:28:22]

Committed patchset #2 manually as r22268 (presubmit successful).