Issue 368783006: Treat ExecutableAccessorInfo as regular data properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 368783006: Treat ExecutableAccessorInfo as regular data properties. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
mvstanton, dcarney, rafaelw

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Treat ExecutableAccessorInfo as regular data properties. BUG= R=dcarney@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22236

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -50 lines)			Patch
M	src/accessors.cc	View	2 chunks	+2 lines, -17 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+18 lines, -0 lines	2 comments	Download
M	test/cctest/test-api.cc	View	10 chunks	+47 lines, -31 lines	0 comments	Download
M	test/mjsunit/es7/object-observe.js	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

LGTM, couple comments. https://codereview.chromium.org/368783006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/368783006/diff/1/src/objects.cc#newcode3094 src/objects.cc:3094: *done = result.IsReadOnly(); How about *done ...

6 years, 5 months ago (2014-07-03 09:33:09 UTC) #3

Toon Verwaest

6 years, 5 months ago (2014-07-07 11:00:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22236 (presubmit successful).

Expand Messages | Collapse Messages