Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: Source/core/rendering/RenderListItem.h

Issue 368733002: Split list marker updating into two steps (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address reviewer comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLLIElement.cpp ('k') | Source/core/rendering/RenderListItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderListItem.h
diff --git a/Source/core/rendering/RenderListItem.h b/Source/core/rendering/RenderListItem.h
index 3d6edc57c94c891a20200eefa9d0a7dd0207661c..ca46d46bf42b727c7cd727d980f65c392b1069f6 100644
--- a/Source/core/rendering/RenderListItem.h
+++ b/Source/core/rendering/RenderListItem.h
@@ -42,13 +42,12 @@ public:
void setExplicitValue(int value);
void clearExplicitValue();
- void setNotInList(bool notInList) { m_notInList = notInList; }
+ void setNotInList(bool);
bool notInList() const { return m_notInList; }
const String& markerText() const;
void updateListMarkerNumbers();
- void updateMarkerLocation();
static void updateItemValuesForOrderedList(const HTMLOListElement*);
static unsigned itemCountForOrderedList(const HTMLOListElement*);
@@ -69,6 +68,10 @@ private:
virtual void layout() OVERRIDE;
+ // Returns true if we re-attached and updated the location of the marker.
+ bool updateMarkerLocation();
+ void updateMarkerLocationAndInvalidateWidth();
+
void positionListMarker();
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;
« no previous file with comments | « Source/core/html/HTMLLIElement.cpp ('k') | Source/core/rendering/RenderListItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698