Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 36873002: Pass '-g -O1 -fno-inline -fno-inline-functions' when building with tsan=1 (Closed)

Created:
7 years, 2 months ago by Alexander Potapenko
Modified:
7 years, 2 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Visibility:
Public.

Description

Pass '-g -O1 -fno-inline -fno-inline-functions' when building with tsan=1 to let ThreadSanitizer print accurate stacks with addr2line. BUG=310479 TBR=jyasskin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
TBR
7 years, 2 months ago (2013-10-23 09:20:48 UTC) #1
Alexander Potapenko
7 years, 2 months ago (2013-10-23 09:21:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r230380 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698