DevTools: Make addFileForURL more robust

Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js

Index: Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js
diff --git a/Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js b/Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js
index 643113f86ea61e3e8762c1cc652d162ce9e2a203..fc67ec2d7eaa1c3457f815bf10c985a61698dbf3 100644
--- a/Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js
+++ b/Source/devtools/front_end/sdk/NetworkWorkspaceBinding.js
@@ -129,8 +129,14 @@ WebInspector.NetworkWorkspaceBinding.prototype = {
     {
         var splitURL = WebInspector.ParsedURL.splitURL(url);
         var projectName = splitURL[0];
-        var parentPath = decodeURI(splitURL.slice(1, splitURL.length - 1).join("/"));
-        var name = decodeURI(splitURL[splitURL.length - 1]);
+        var parentPath = splitURL.slice(1, -1).join("/");
+        try {
+            parentPath = decodeURIComponent(parentPath);

[aandrey, 2014/07/01 18:21:52]

FYI, there are decodeURI(), decodeURIComponent() and unescape().
Are you sure you use the correct one?

[alph, 2014/07/02 09:49:22]

Thanks, I know about these.
decodeURI is supposed to be called on complete URIs.
unescape is deprecated.
decodeURIComponent seems to be the one to use here. Though ideally it should be
called on each component before join, but it works this way as well.

Do you have a specific concern?

+        } catch (e) { }
+        var name = splitURL.peekLast() || "";
+        try {
+            name = decodeURIComponent(name);
+        } catch (e) { }
         var projectDelegate = this._projectDelegate(projectName, isContentScript || false);
         var path = projectDelegate.addFile(parentPath, name, url, contentProvider);
         var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (this._workspace.uiSourceCode(projectDelegate.id(), path));