Issue 36863002: Remove redundant scheduleDelayedAction in Audio constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 36863002: Remove redundant scheduleDelayedAction in Audio constructor (Closed)

Created:
7 years, 2 months ago by philipj_slow

Modified:
7 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove redundant scheduleDelayedAction in Audio constructor Setting the src attribute will trigger HTMLMediaElement::parseAttribute, which already calls scheduleDelayedAction when src is modified. This is already tested by LayoutTests/media/audio-constructor-src.html BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160333

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
		Source/core/html/HTMLAudioElement.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/36863002/1

7 years, 2 months ago (2013-10-23 09:42:09 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=13308

7 years, 2 months ago (2013-10-23 11:11:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/36863002/1

7 years, 2 months ago (2013-10-23 11:24:40 UTC) #5

Message was sent while issue was closed.

Change committed as 160333

Expand Messages | Collapse Messages