Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 368573002: Hide symbols in S32A_Opaque_BlitRow32_SSE4

Created:
6 years, 5 months ago by henrik.smiding
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Hide symbols in S32A_Opaque_BlitRow32_SSE4 Marks the symbols in the S32A_Opaque_BlitRow32_SSE4 files as hidden, so Chromium can build. Also enables the optimizations. Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; Committed: https://skia.googlesource.com/skia/+/4a2489f7bbaccfe588597193561526d579004653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/opts/SkBlitRow_opts_SSE4.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE4_asm.S View 1 chunk +3 lines, -1 line 0 comments Download
M src/opts/SkBlitRow_opts_SSE4_x64_asm.S View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
henrik.smiding
6 years, 5 months ago (2014-07-01 11:08:55 UTC) #1
mtklein
lgtm
6 years, 5 months ago (2014-07-01 12:56:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/henrik.smiding@intel.com/368573002/1
6 years, 5 months ago (2014-07-01 12:57:26 UTC) #3
commit-bot: I haz the power
Change committed as 4a2489f7bbaccfe588597193561526d579004653
6 years, 5 months ago (2014-07-01 13:12:53 UTC) #4
bungeman-skia
On 2014/07/01 13:12:53, I haz the power (commit-bot) wrote: > Change committed as 4a2489f7bbaccfe588597193561526d579004653 I ...
6 years, 5 months ago (2014-07-01 15:45:44 UTC) #5
mtklein
On 2014/07/01 15:45:44, bungeman1 wrote: > On 2014/07/01 13:12:53, I haz the power (commit-bot) wrote: ...
6 years, 5 months ago (2014-07-01 15:48:31 UTC) #6
tomhudson
6 years, 5 months ago (2014-07-02 18:49:38 UTC) #7
Reopening. There may still be a problem here; this change seems to be implicated
in http://crbug.com/391016?

Powered by Google App Engine
This is Rietveld 408576698