Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 368533003: Revert of Call media query change listeners asynchronously. (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, kenneth.christiansen, Mike Lawther (Google), rjwright, rwlbuis, rune+blink, shans, sof, Steve Block, Timothy Loh, Yoav Weiss
Project:
blink
Visibility:
Public.

Description

Revert of Call media query change listeners asynchronously. (https://codereview.chromium.org/337883003/) Reason for revert: The patch broke inspector-protocol/css/media-query-listener-exception.html on Mac http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=http/tests/websocket/workers/close-code-and-reason.html,inspector-protocol/css/media-query-listener-exception.html Original issue's description: > Call media query change listeners asynchronously. > > BUG=356487 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177267 TBR=esprehn@chromium.org,yoav@yoav.ws,cbiesinger@chromium.org NOTREECHECKS=true NOTRY=true BUG=356487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -83 lines) Patch
M LayoutTests/fast/media/media-query-list-listener.html View 2 chunks +19 lines, -28 lines 0 comments Download
M LayoutTests/fast/media/media-query-list-listener-ordering.html View 2 chunks +4 lines, -6 lines 0 comments Download
M LayoutTests/inspector-protocol/css/media-query-listener-exception.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQueryListListener.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryListListener.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.h View 4 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 6 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
Created Revert of Call media query change listeners asynchronously.
6 years, 5 months ago (2014-07-01 08:12:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/368533003/1
6 years, 5 months ago (2014-07-01 08:13:20 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 08:13:27 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 08:13:28 UTC) #4
Failed to apply patch for Source/core/css/MediaQueryListListener.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/MediaQueryListListener.h
  Hunk #1 FAILED at 22.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/MediaQueryListListener.h.rej

Patch:       Source/core/css/MediaQueryListListener.h
Index: Source/core/css/MediaQueryListListener.h
diff --git a/Source/core/css/MediaQueryListListener.h
b/Source/core/css/MediaQueryListListener.h
index
4895b82ea534484ed37221ce415ef49845c9854a..d9299b0b3d650dd345c4febcb4dc8022ea23a282
100644
--- a/Source/core/css/MediaQueryListListener.h
+++ b/Source/core/css/MediaQueryListListener.h
@@ -22,7 +22,6 @@
 
 #include "bindings/v8/ScriptState.h"
 #include "bindings/v8/ScriptValue.h"
-#include "core/css/MediaQueryList.h"
 #include "platform/heap/Handle.h"
 #include "wtf/RefCounted.h"
 
@@ -40,8 +39,6 @@
             return nullptr;
         return adoptRefWillBeNoop(new MediaQueryListListener(scriptState,
value));
     }
-    ~MediaQueryListListener();
-
     void call();
 
     // Used to keep the MediaQueryList alive and registered with the
MediaQueryMatcher

Powered by Google App Engine
This is Rietveld 408576698