Issue 368433006: Reland "Linux perf tool support update + refactoring."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 368433006: Reland "Linux perf tool support update + refactoring." (Closed)

Created:
6 years, 5 months ago by Jarin

Modified:
6 years, 5 months ago

Reviewers:
jbramley, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Reland "Linux perf tool support update + refactoring." This relands r22098. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22118

Patch Set 1 : Original commit #

Patch Set 2 : Fix Android builder #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+410 lines, -173 lines)			Patch
M	BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/android.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/base/platform/platform.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/base/platform/platform-posix.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/base/platform/platform-win32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/log.cc	View		2 chunks	+1 line, -166 lines	0 comments	Download
A	src/perf-jit.h	View		1 chunk	+129 lines, -0 lines	0 comments	Download
A	src/perf-jit.cc	View		1 chunk	+169 lines, -0 lines	1 comment	Download
A	src/third_party/kernel/tools/perf/util/jitdump.h	View		1 chunk	+85 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2014/07/01 12:08:15, jarin wrote: > Could you have another look? lgtm.

6 years, 5 months ago (2014-07-01 12:09:18 UTC) #2

Jarin

Committed patchset #2 manually as r22118 (presubmit successful).

6 years, 5 months ago (2014-07-01 12:21:02 UTC) #3

jbramley

6 years, 5 months ago (2014-07-01 12:38:23 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/368433006/diff/20001/src/perf-jit.cc
File src/perf-jit.cc (right):

https://codereview.chromium.org/368433006/diff/20001/src/perf-jit.cc#newcode85
src/perf-jit.cc:85: close(clock_fd_);
This produces an error for me because 'close' isn't defined. (It's in
"unistd.h", but I'm not sure about platforms without that header.)

I thought this was what made it fail on the builders, but I still see the
problem after r22118.

Expand Messages | Collapse Messages