Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: cc/quads/render_pass.h

Issue 368403003: Use RenderPass to create DrawQuad in unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layerrawptrDQ
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/software_renderer_unittest.cc ('k') | cc/quads/render_pass.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/quads/render_pass.h
diff --git a/cc/quads/render_pass.h b/cc/quads/render_pass.h
index ce5a90e514d8772695c0be2d91203adfa0665795..6b68f8d910b4c4065ef3d53bd1e45ce0be6cf843 100644
--- a/cc/quads/render_pass.h
+++ b/cc/quads/render_pass.h
@@ -24,6 +24,7 @@ class Value;
namespace cc {
class DrawQuad;
+class RenderPassDrawQuad;
class CopyOutputRequest;
class SharedQuadState;
@@ -96,6 +97,13 @@ class CC_EXPORT RenderPass {
return static_cast<DrawQuadType*>(quad_list.back());
}
+ RenderPassDrawQuad* CopyFromAndAppendRenderPassDrawQuad(
+ const RenderPassDrawQuad* quad,
+ const SharedQuadState* shared_quad_state,
+ RenderPass::Id render_pass_id);
+ DrawQuad* CopyFromAndAppendDrawQuad(const DrawQuad* quad,
+ const SharedQuadState* shared_quad_state);
+
// Uniquely identifies the render pass in the compositor's current frame.
Id id;
@@ -124,6 +132,14 @@ class CC_EXPORT RenderPass {
RenderPass();
private:
+ template <typename DrawQuadType>
+ DrawQuadType* CopyFromAndAppendTypedDrawQuad(const DrawQuad* quad) {
+ scoped_ptr<DrawQuadType> draw_quad =
+ make_scoped_ptr(new DrawQuadType(*DrawQuadType::MaterialCast(quad)));
+ quad_list.push_back(draw_quad.template PassAs<DrawQuad>());
+ return static_cast<DrawQuadType*>(quad_list.back());
+ }
+
DISALLOW_COPY_AND_ASSIGN(RenderPass);
};
« no previous file with comments | « cc/output/software_renderer_unittest.cc ('k') | cc/quads/render_pass.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698