Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 368313003: Improve YouCompleteMe handling of Blink header without source files. (Closed)

Created:
6 years, 5 months ago by jbroman
Modified:
6 years, 5 months ago
Reviewers:
eroman
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Improve YouCompleteMe handling of Blink header without source files. In this case, simply giving the Chromium src root as the include path is unlikely to be helpful. We can get a pretty close approximation by getting the flags for an arbitrary Blink source file, which will have more reasonable include paths and defines for a Blink header. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281759

Patch Set 1 #

Patch Set 2 : config.h also helpful #

Total comments: 2

Patch Set 3 : os.path.join #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M tools/vim/chromium.ycm_extra_conf.py View 1 2 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
6 years, 5 months ago (2014-07-03 16:55:00 UTC) #1
eroman
lgtm https://codereview.chromium.org/368313003/diff/10002/tools/vim/chromium.ycm_extra_conf.py File tools/vim/chromium.ycm_extra_conf.py (right): https://codereview.chromium.org/368313003/diff/10002/tools/vim/chromium.ycm_extra_conf.py#newcode135 tools/vim/chromium.ycm_extra_conf.py:135: blink_root = chrome_root + '/third_party/WebKit' rather than direct ...
6 years, 5 months ago (2014-07-08 01:10:42 UTC) #2
jbroman
https://codereview.chromium.org/368313003/diff/10002/tools/vim/chromium.ycm_extra_conf.py File tools/vim/chromium.ycm_extra_conf.py (right): https://codereview.chromium.org/368313003/diff/10002/tools/vim/chromium.ycm_extra_conf.py#newcode135 tools/vim/chromium.ycm_extra_conf.py:135: blink_root = chrome_root + '/third_party/WebKit' On 2014/07/08 01:10:42, eroman ...
6 years, 5 months ago (2014-07-08 13:09:53 UTC) #3
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-08 13:09:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/368313003/30001
6 years, 5 months ago (2014-07-08 13:10:32 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 15:37:37 UTC) #6
Message was sent while issue was closed.
Change committed as 281759

Powered by Google App Engine
This is Rietveld 408576698