Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 368313002: ARM64: Generate better immediates for shifted ops (Closed)

Created:
6 years, 5 months ago by m.m.capewell
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ARM64: Generate better immediates for shifted ops Improve code generated for immediate data processing operations where the shift on the operation can be exploited to use fewer instructions for the immediate. For example, Add(x0, x0, 0x1f7de) used to generate: movz x16, 0xf7de movk x16, 0x1, lsl #16 add x0, x0, x16 now generates: movz x16, 0xfbef add x0, x0, x16, lsl #1 BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22246

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment about bit setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -23 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 4 chunks +76 lines, -19 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
m.m.capewell
6 years, 5 months ago (2014-07-03 16:33:26 UTC) #1
ulan
lgtm https://codereview.chromium.org/368313002/diff/1/src/arm64/macro-assembler-arm64.cc File src/arm64/macro-assembler-arm64.cc (right): https://codereview.chromium.org/368313002/diff/1/src/arm64/macro-assembler-arm64.cc#newcode449 src/arm64/macro-assembler-arm64.cc:449: // inserting set bits in the least-significant bits. ...
6 years, 5 months ago (2014-07-07 07:42:20 UTC) #2
m.m.capewell
https://codereview.chromium.org/368313002/diff/1/src/arm64/macro-assembler-arm64.cc File src/arm64/macro-assembler-arm64.cc (right): https://codereview.chromium.org/368313002/diff/1/src/arm64/macro-assembler-arm64.cc#newcode449 src/arm64/macro-assembler-arm64.cc:449: // inserting set bits in the least-significant bits. On ...
6 years, 5 months ago (2014-07-07 13:28:03 UTC) #3
m.m.capewell
6 years, 5 months ago (2014-07-07 13:31:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698