dart/site/try/src/compilation.dart - Issue 368293002: Fix warnings about unused code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/site/try/src/compilation.dart

Issue 368293002: Fix warnings about unused code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/site/try/src/compilation.dart

diff --git a/dart/site/try/src/compilation.dart b/dart/site/try/src/compilation.dart

index d9b28afb0b3c7af711727c306b0a540da1475ac7..0fcc7937089ab020dd17cb61b6574183475fd45c 100644

--- a/dart/site/try/src/compilation.dart

+++ b/dart/site/try/src/compilation.dart

@@ -139,8 +139,7 @@ class CompilationProcess {

}

onFail(_) {

- // TODO(ahe): Call interaction.onCompilationFailed().

- interaction.consolePrintLine('Compilation failed');

+ interaction.onCompilationFailed();

ahe 2014/07/03 14:44:50 Bad merge.

}

onDone(_) {

@@ -256,6 +255,6 @@ self.importScripts("$url");

}

onCrash(data) {

- interaction.consolePrintLine(data);

+ interaction.onCompilerCrash(data);

ahe 2014/07/03 14:44:50 Bad merge.

}

« no previous file with comments | « no previous file | dart/site/try/src/editor.dart » ('j') | dart/site/try/src/interaction_manager.dart » ('J')